Use expected_files.add as context manager where applicable - #22337
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates tests to use expected_files.add(...) directly as a context manager.
Changes:
- Consolidates expected-file registration and writing.
- Removes redundant direct file-opening calls.
Show a summary per file
| File | Description |
|---|---|
swift/ql/integration-tests/posix/frontend-invocations/test.py |
Writes hashes through the fixture context manager. |
misc/pytest/lib/query_suites.py |
Writes query-suite results through the fixture. |
java/ql/integration-tests/kotlin/all-platforms/logs/test.py |
Writes normalized logs through the fixture. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
jketema
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22329 (comment).