Rust: Add a couple of new metrics to rust/summary/summary-statistics. - #22328
Open
geoffw0 wants to merge 3 commits into
Open
Rust: Add a couple of new metrics to rust/summary/summary-statistics.#22328geoffw0 wants to merge 3 commits into
geoffw0 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds broader extraction and taint-graph metrics to Rust summary statistics.
Changes:
- Distinguishes user files from all extracted files.
- Reports highly colocated data-flow nodes.
- Updates reduced-summary expectations for the renamed metric.
Show a summary per file
| File | Description |
|---|---|
rust/ql/src/queries/summary/Stats.qll |
Defines the new metrics. |
rust/ql/src/queries/summary/SummaryStats.ql |
Includes additional extraction statistics. |
rust/ql/test/query-tests/diagnostics/SummaryStatsReduced.expected |
Updates the expected metric name. |
rust/ql/integration-tests/hello-workspace/summary.rust-project.expected |
Updates rust-project expectations. |
rust/ql/integration-tests/hello-workspace/summary.cargo.expected |
Updates Cargo expectations. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a couple of new metrics to
rust/summary/summary-statistics:(I'm going to do a small DCA run because there's some integration between this query and the reports there, to be sure I haven't broken anything)