Python: Remove redundant collection taint summaries - #22314
Open
hvitved wants to merge 3 commits into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes redundant collection-level taint summaries following the improved collection taint handling from #21888.
Changes:
- Removes element-to-container fallback summaries for
list.appendandset.add. - Retains element-content flow summaries.
Show a summary per file
| File | Description |
|---|---|
python/ql/lib/semmle/python/frameworks/Stdlib.qll |
Simplifies list and set mutation taint summaries. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
hvitved
marked this pull request as draft
August 11, 2026 07:38
hvitved
marked this pull request as ready for review
August 11, 2026 10:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #21888, collection taint handling now makes the explicit element-to-container fallback summaries for
list.appendandset.addredundant.Remove those fallback edges and their TODO comments while retaining the element-content flow summaries.
Testing
codeql test run python/ql/test/library-tests/dataflow/tainttracking/defaultAdditionalTaintStep --threads=0