JS: Add support for ES2022's \d flag - #22309
Open
MathiasVP wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ECMAScript 2022 support for the regular-expression d flag.
Changes:
- Allows
dfor ECMAScript edition 13 and later. - Adds extraction coverage and expected TRAP output.
Show a summary per file
| File | Description |
|---|---|
Parser.java |
Extends valid regular-expression flags. |
d-flag.js |
Adds an ES2022 test case. |
d-flag.js.trap |
Records expected extraction output. |
options.json |
Enables experimental syntax for the test. |
Review details
Tip
Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
\d flag\d flag
asgerf
reviewed
Aug 10, 2026
asgerf
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing! Could you add a change note? Otherwise LGTM
MathiasVP
force-pushed
the
js-add-support-for-d-flag
branch
from
August 10, 2026 12:22
3d22f66 to
224ab74
Compare
Contributor
Author
Sure! Done in 224ab74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin.
cc @asgerf