Ruby: Approximate FieldContent in data flow. - #22306
Draft
aschackmull wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field content is usually the prime candidate for approximation in
ContentApproxto ensure decent data flow performance (in stage 3). We've usually done something along the lines of using the first (interesting) letter of the field name, but I figured I might as well just bucket the names based on a ranking. I initially chose 30 buckets as a guess towards the same level of approximation as picking a letter. I then compared it to both 20 and 50 and indeed 30 seemed like a decent sweet spot.