Ruby: Switch regex tracking from TypeTracking to DataFlow. - #22296
Open
aschackmull wants to merge 2 commits into
Open
Ruby: Switch regex tracking from TypeTracking to DataFlow.#22296aschackmull wants to merge 2 commits into
aschackmull wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Switches Ruby regular-expression tracking from custom type tracking to stateful global data flow for improved precision.
Changes:
- Adds string and regular-expression flow states.
- Replaces custom tracking machinery with
GlobalWithState.
Show a summary per file
| File | Description |
|---|---|
ruby/ql/lib/codeql/ruby/regexp/internal/RegExpTracking.qll |
Implements stateful data-flow-based regex tracking. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
aschackmull
force-pushed
the
ruby/regex-via-dataflow
branch
from
August 7, 2026 11:56
0a0ac9e to
a2b6c1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dca on #22256 highlighted a lot of imprecision in regex tracking. This PR attempts to improve this by simply swapping the flow computation from TypeTracking to DataFlow.