Add repr() and %r sanitizers to py/log-injection query to reduce false positives#22026
Open
mrigankpawagi wants to merge 2 commits into
Open
Add repr() and %r sanitizers to py/log-injection query to reduce false positives#22026mrigankpawagi wants to merge 2 commits into
mrigankpawagi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the
py/log-injectionquery by recognizingrepr()and the%rformat specifier as sanitizers for log injection. This is a very common false positive pattern for this query.Note: This PR currently only contains new test cases in order to demonstrate the false positive pattern. Once that is demonstrated from the CI, I will push the fix.