Go: more models for log.slog#22006
Open
owen-mc wants to merge 2 commits into
Open
Conversation
Contributor
Click to show differences in coveragegoGenerated file changes for go
- `Standard library <https://pkg.go.dev/std>`_,"````, ``archive/*``, ``bufio``, ``bytes``, ``cmp``, ``compress/*``, ``container/*``, ``context``, ``crypto``, ``crypto/*``, ``database/*``, ``debug/*``, ``embed``, ``encoding``, ``encoding/*``, ``errors``, ``expvar``, ``flag``, ``fmt``, ``go/*``, ``hash``, ``hash/*``, ``html``, ``html/*``, ``image``, ``image/*``, ``index/*``, ``io``, ``io/*``, ``log``, ``log/*``, ``maps``, ``math``, ``math/*``, ``mime``, ``mime/*``, ``net``, ``net/*``, ``os``, ``os/*``, ``path``, ``path/*``, ``plugin``, ``reflect``, ``reflect/*``, ``regexp``, ``regexp/*``, ``slices``, ``sort``, ``strconv``, ``strings``, ``sync``, ``sync/*``, ``syscall``, ``syscall/*``, ``testing``, ``testing/*``, ``text/*``, ``time``, ``time/*``, ``unicode``, ``unicode/*``, ``unsafe``, ``weak``",52,612,124
+ `Standard library <https://pkg.go.dev/std>`_,"````, ``archive/*``, ``bufio``, ``bytes``, ``cmp``, ``compress/*``, ``container/*``, ``context``, ``crypto``, ``crypto/*``, ``database/*``, ``debug/*``, ``embed``, ``encoding``, ``encoding/*``, ``errors``, ``expvar``, ``flag``, ``fmt``, ``go/*``, ``hash``, ``hash/*``, ``html``, ``html/*``, ``image``, ``image/*``, ``index/*``, ``io``, ``io/*``, ``log``, ``log/*``, ``maps``, ``math``, ``math/*``, ``mime``, ``mime/*``, ``net``, ``net/*``, ``os``, ``os/*``, ``path``, ``path/*``, ``plugin``, ``reflect``, ``reflect/*``, ``regexp``, ``regexp/*``, ``slices``, ``sort``, ``strconv``, ``strings``, ``sync``, ``sync/*``, ``syscall``, ``syscall/*``, ``testing``, ``testing/*``, ``text/*``, ``time``, ``time/*``, ``unicode``, ``unicode/*``, ``unsafe``, ``weak``",52,625,127
- Totals,,688,1072,1577
+ Totals,,688,1085,1580
- log,40,,3,,,,40,,,,,,,,,,,,,,,,,,,3,
+ log,43,,16,,,,43,,,,,,,,,,,,,,,,,,,16, |
Contributor
There was a problem hiding this comment.
⚠️ Not ready to approve
The updated change note is now incomplete/inaccurate relative to the expanded log/slog modeling added in this PR.
Pull request overview
This PR extends the Go standard-library log/slog modeling to cover additional APIs beyond the core logging calls, building on the earlier LoggerCall/log-injection support to improve query coverage and model validation.
Changes:
- Add
log/slogmodels forWith/WithGroupaslog-injectionsinks and add summary models forAttr/Valueconstruction/accessors. - Add a new
frameworks/Sloglibrary-test module to validate taint/value flows through the new models. - Extend the
LoggerCallconcept library test cases to includeWith/WithGroup.
File summaries
| File | Description |
|---|---|
| go/ql/test/library-tests/semmle/go/frameworks/Slog/test.go | New Go test cases exercising slog calls, Logger methods, With/WithGroup, and Attr/Value helpers. |
| go/ql/test/library-tests/semmle/go/frameworks/Slog/TaintFlows.ql | New inline-flow test query configuration for validating modeled sinks/summaries. |
| go/ql/test/library-tests/semmle/go/frameworks/Slog/TaintFlows.expected | Expected output marker file for the inline-flow test. |
| go/ql/test/library-tests/semmle/go/frameworks/Slog/go.mod | New Go module file (Go 1.21) for the Slog library test. |
| go/ql/test/library-tests/semmle/go/concepts/LoggerCall/slog.go | Adds With/WithGroup cases to the LoggerCall library test. |
| go/ql/lib/ext/log.slog.model.yml | Adds sink models for With/WithGroup and summary models for Attr/Value constructors/accessors. |
| go/ql/lib/change-notes/2026-06-17-model-log-slog.md | Updates the change note text (needs adjustment to reflect the full modeled surface). |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 1
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
7e63be1 to
f76a14e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on from #22004.