Skip to content

C/C++ overlay: avoid massive cartesian product in overlay discardElement #21939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
IdrissRio wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −6
Draft

C/C++ overlay: avoid massive cartesian product in overlay discardElement #21939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions cpp/ql/lib/semmle/code/cpp/internal/Overlay.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,13 @@ private predicate discardElement(@element e) {
// particular, been deleted), or the overlay has redefined the TRAP
// file or tag it is in, or the overlay runner has re-extracted the same
// source file (e.g. because a header it includes has changed).
forall(@trap_or_tag t, string sourceFile |
not exists(@trap_or_tag t |
locallyInTrapOrTag(false, e, t) and
locallyReachableTrapOrTag(false, sourceFile, t)
|
overlayChangedFiles(sourceFile) or
locallyReachableTrapOrTag(true, _, t) or
locallyReachableTrapOrTag(true, sourceFile, _)
not locallyReachableTrapOrTag(true, _, t) and
exists(string sourceFile |
locallyReachableTrapOrTag(false, sourceFile, t) and
not overlayChangedFiles(sourceFile) and
not locallyReachableTrapOrTag(true, sourceFile, _)
)
)
}
Loading