Go: Remove global function step from local flow#21721
Draft
owen-mc wants to merge 1 commit intogithub:mainfrom
Draft
Go: Remove global function step from local flow#21721owen-mc wants to merge 1 commit intogithub:mainfrom
owen-mc wants to merge 1 commit intogithub:mainfrom
Conversation
06b9b76 to
f275b9a
Compare
f275b9a to
f6135b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be good if the local flow relation was really local. There was one disjunct which isn't. I tried removing it and only one test failed, and on investigation this was easily fixed. I will run DCA and QA to see if there are any alert changes from this. My best guess is that it's somehow related to assigning global functions to variables (or using them as arguments), but since go doesn't use the lambda flow capabilities of the data flow library it probably isn't doing anything.