Skip to content

Fix false positive in MissedSelectOpportunity when foreach body uses await #21708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 3 commits into from
Apr 15, 2026
Merged

Fix false positive in MissedSelectOpportunity when foreach body uses await #21708

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e66555
Initial plan
Copilot Apr 14, 2026
3483050
Fix false positive in MissedSelectOpportunity for async/await loops
Copilot Apr 14, 2026
878cfd7
C#: Use inline test expectations
hvitved Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
C#: Use inline test expectations
  • Loading branch information
@hvitved
hvitved committed Apr 14, 2026
commit 878cfd720ca909b35c25b5caecf09b32deb811f2
2 changes: 1 addition & 1 deletion csharp/ql/test/query-tests/Linq/MissedSelectOpportunity/MissedSelectOpportunity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public void M1(List<int> lst)
{
int j = i * i;
Console.WriteLine(j);
}
} // $ Alert
Comment thread
hvitved marked this conversation as resolved.
}

public async Task M2(IEnumerable<ICounter> counters)
Expand Down
3 changes: 2 additions & 1 deletion csharp/ql/test/query-tests/Linq/MissedSelectOpportunity/MissedSelectOpportunity.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Linq/MissedSelectOpportunity.ql
query: Linq/MissedSelectOpportunity.ql
postprocess: utils/test/InlineExpectationsTestQuery.ql
Loading