Skip to content

Rust: Fix performance issue with additionalExternalFile #21671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffw0 merged 2 commits into from
Apr 10, 2026
+4 −1
Merged

Rust: Fix performance issue with additionalExternalFile #21671

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95681bf
Rust: Fix performance issue with File.fromSource.
geoffw0 Mar 9, 2026
e72c116
Rust: Proposed improved solution.
geoffw0 Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rust: Proposed improved solution.
  • Loading branch information
@geoffw0
geoffw0 committed Apr 9, 2026
commit e72c1166640ddddfae86897cf24443da0dc90dd7
4 changes: 2 additions & 2 deletions rust/ql/lib/codeql/files/FileSystem.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@ extensible predicate additionalExternalFile(string relativePath);
/** A file. */
class File extends Container, Impl::File {
pragma[nomagic]
private string getRelativePath0() { result = this.getRelativePath() }
private predicate isAdditionalExternalFile() { additionalExternalFile(this.getRelativePath()) }

/**
* Holds if this file was extracted from the source code of the target project
* (rather than another location such as inside a dependency).
*/
predicate fromSource() {
exists(ExtractorStep s | s.getAction() = "Extract" and s.getFile() = this) and
not additionalExternalFile(this.getRelativePath0())
not this.isAdditionalExternalFile()
}

/**
Expand Down
Loading