Skip to content

Kotlin: clamp -language-version to 1.9 #21545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
redsun82 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Kotlin: clamp -language-version to 1.9 #21545

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc59232
Kotlin: clamp `-language-version` to 1.9
redsun82 Mar 23, 2026
d2df48d
Merge branch 'main' into redsun82/kotlin-language-version-min-1.9
redsun82 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Kotlin: clamp -language-version to 1.9 
This is an experiment to see if compiling the 1.8 kotlin extractor with
`-language-version=1.9` will cause problems. It it works, it will allow
us to use a 2.3.x toolchain (which doesn't support 1.8 any more).
  • Loading branch information
@redsun82
redsun82 committed Mar 23, 2026
commit bc592328e589c64b78322a51e187f434073a033c
2 changes: 2 additions & 0 deletions java/kotlin-extractor/versions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ def version_less(lhs, rhs):

def get_language_version(version):
major, minor, _ = _version_to_tuple(version)
if major == 1 and minor < 9:
return "1.9"
return "%s.%s" % (major, minor)

def _basename(path):
Expand Down
Loading