C++: add InitializeIndirection for pointer params#2154
Merged
dbartol merged 13 commits intoDec 20, 2019
Conversation
Contributor
Author
|
There's a few comments with questions/TODOs in TranslatedFunction.qll, mostly relating to types and handling of buffers. If I need to handle sized buffers with sizes from later parameters, I expect that to be a fairly large refactor. |
added 2 commits
October 18, 2019 12:15
jbj
reviewed
Oct 24, 2019
added 8 commits
October 28, 2019 15:09
Contributor
Author
|
This is finally up to date and ready for review |
Contributor
|
No further objections from me. I'll leave the reviewing of the QL code to @dbartol. |
dbartol
approved these changes
Dec 20, 2019
dbartol
left a comment
There was a problem hiding this comment.
LGTM
The QL changes look good. The IR diffs look like what I'd expect, given that we still treat parameters as pointing to escaped memory. These should look better once I get the aliased indirection support merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.