Skip to content

C#: Overlay extraction support. #20425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelnebel merged 27 commits into from
Nov 12, 2025
Merged

C#: Overlay extraction support. #20425

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b600255
C#: Enable overlay compilation in lib/qlpack.yml.
michaelnebel Oct 21, 2025
bcc6234
C#: Fix bad join due to overlay compilation.
michaelnebel Oct 29, 2025
b48ce8d
C#: Add overlay builtins to the dbscheme.
michaelnebel Sep 12, 2025
cfb6843
C#: Add upgrade- and downgrade scripts.
michaelnebel Sep 12, 2025
9026a5a
C#: Turn on overlay support in codeql-extractor.yml.
michaelnebel Sep 12, 2025
aa80558
C#: Add functionality to detect overlay mode and integrate in extract…
michaelnebel Sep 12, 2025
cab9d81
C#: Add unit test.
michaelnebel Sep 12, 2025
61f6512
C#: Sprinkle uses of OnlyScaffold to extract less when in overlay mode.
michaelnebel Sep 17, 2025
76ac2df
C#: Write overlay metadata at end of extraction.
michaelnebel Oct 21, 2025
121c150
C#: Define discarding predicates for expressions, statements, locatio…
michaelnebel Oct 23, 2025
8a34421
C#: Add QL overlay tests.
michaelnebel Oct 27, 2025
40035d2
C#: Add a locatable type to the dbscheme.
michaelnebel Oct 27, 2025
8927b0a
C#: Simplify the discarding and also discard type mentions and comments.
michaelnebel Oct 27, 2025
04d33cb
C#: Add discarding for diagnostics and extractor messages.
michaelnebel Oct 28, 2025
1d2f154
C#: Add change-note.
michaelnebel Oct 30, 2025
504bb9c
C#: Only scaffold assemblies in overlay mode, only extract expression…
michaelnebel Nov 3, 2025
d95ebc7
C#: Add using directives and type mentions as star entities.
michaelnebel Nov 3, 2025
7c670cd
C#: Address review comments and make more early returns in Populate.
michaelnebel Nov 7, 2025
1657dfb
C#: Remove expression population safeguard and guard creation of cons…
michaelnebel Nov 7, 2025
9d300e3
C#: Address comments in the QL implementation.
michaelnebel Nov 7, 2025
ded1328
C#: Do not extract comments when scaffolding.
michaelnebel Nov 10, 2025
43118ec
C#: The extraction of the TypeMentions for return type and explicit i…
michaelnebel Nov 10, 2025
0a16cf6
C#: Do not require that comments and type locations are in source in …
michaelnebel Nov 10, 2025
c44b747
C#: Minor code quality improvements.
michaelnebel Nov 10, 2025
d6b7424
C#: Add the same strategy in as in Java for XML element discarding.
michaelnebel Nov 10, 2025
3492811
C#: Add XML overlay tests.
michaelnebel Nov 10, 2025
0541dcc
C#: Add discarding for ASP elements.
michaelnebel Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
C#: Remove expression population safeguard and guard creation of cons… 
…tructor initializer expressions.
  • Loading branch information
@michaelnebel
michaelnebel committed Nov 7, 2025
commit 1657dfb5516692ee2a4ef8cba766689a466cff19
3 changes: 2 additions & 1 deletion csharp/extractor/Semmle.Extraction.CSharp/Entities/Constructor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ protected override void ExtractInitializers(TextWriter trapFile)
// Do not extract initializers for constructed types.
// Extract initializers for constructors with a body, primary constructors
// and default constructors for classes and structs declared in source code.
if (Block is null && ExpressionBody is null && !MakeSynthetic)
if (Block is null && ExpressionBody is null && !MakeSynthetic || Context.OnlyScaffold)
{
return;
}
Expand Down Expand Up @@ -113,6 +113,7 @@ protected override void ExtractInitializers(TextWriter trapFile)
}

var baseConstructorTarget = Create(Context, baseConstructor);

var info = new ExpressionInfo(Context,
AnnotatedTypeSymbol.CreateNotAnnotated(baseType),
Location,
Expand Down
5 changes: 0 additions & 5 deletions csharp/extractor/Semmle.Extraction.CSharp/Entities/Expression.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ internal Expression(IExpressionInfo info, bool shouldPopulate = true)

protected sealed override void Populate(TextWriter trapFile)
{
if (Context.OnlyScaffold)
{
return;
}

var type = Type.HasValue ? Entities.Type.Create(Context, Type.Value) : NullType.Create(Context);
trapFile.expressions(this, Kind, type.TypeRef);
if (info.Parent.IsTopLevelParent)
Expand Down