Rust: Refactor type equality#19624
Merged
Merged
Conversation
ac12aa5 to
08277e4
Compare
hvitved
approved these changes
Jun 2, 2025
Contributor
hvitved
left a comment
There was a problem hiding this comment.
Nice! I notice that DCA has both an 8 % performance increase for one project and an 8 % decrease for another, have you investigated that? It seems a bit too high to be just noise.
Contributor
Author
|
A second DCA run didn't reproduce the same slowdowns/speedups so it does seem to be noise after all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a recent optimization to the type path operations the type equality over referencing/borrows had to be duplicated twice. This PR changes the meaning of
typeEqualitysuch that the two paths are just the prefix under which all types are equal. This simplifies things a bit and removes the need for having borrow twice.