Rust: Add variables example with let statement in macro#18330
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (3)
- rust/ql/test/library-tests/variables/Cfg.expected: Language not supported
- rust/ql/test/library-tests/variables/Ssa.expected: Language not supported
- rust/ql/test/library-tests/variables/variables.expected: Language not supported
Comments suppressed due to low confidence (1)
rust/ql/test/library-tests/variables/variables.rs:555
- The variable
var_in_macrois not being correctly identified for read access within the macro. Ensure that the test framework can handle variable accesses within macro expansions.
let_in_macro!(37); // $ MISSING: read_access=var_in_macro
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
hvitved
approved these changes
Dec 19, 2024
Contributor
Sounds reasonable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a variables test with a
letstatement inside a macro.The usage of
var_in_macrodoesn't lead to an instance ofVariableAccess. This is because theVariableandVariableAccessinstance forvar_in_macrodoesn't get matched up insidevariableReachesCand. I'm guessing this is because the rank calculation uses locations, and the nodes in the expansion of the macro all have the same location.