C++: Support C11 _Generic expressions#17138
Conversation
f56660a to
eefc3cf
Compare
| # 14| m14_2(int) = Uninitialized[i] : &:r14_1 | ||
| # 16| r16_1(glval<char *>) = VariableAddress[#return] : | ||
| # 16| r16_2(glval<char[4]>) = StringConstant[int] : | ||
| # 16| r16_2(glval<char[4]>) = Constant[int] : |
There was a problem hiding this comment.
This is due to the the getType on the Value associated with the Generic being of ArrayType (only the underlying type is). This is inconsequential though.
Similar for the almost identical change below.
geoffw0
left a comment
There was a problem hiding this comment.
QL, tests and upgrade/downgrade scripts LGTM.
I trust the upgrade/downgrade scripts have been tested, and that the CI and DCA run looks good on the other PR?
It might be nice to have a test demonstrating data flow through generic expressions, but I won't hold this up for it.
Correct.
The IR tests effectively demonstrate that the IR before and after are identical, so I don't think this adds much. |
No description provided.