Skip to content

Java: Add test for ECJ compiling an enum with a constructor parameter annotation #17137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smowton merged 3 commits into from
Aug 2, 2024
Merged

Java: Add test for ECJ compiling an enum with a constructor parameter annotation #17137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee11307
Add test for ECJ compiling an enum with a constructor parameter annot…
smowton Aug 2, 2024
1ee8767
Switch to measuring just diagnostics
smowton Aug 2, 2024
f891423
Run Maven integration tests sequentially due to conflicts over ~/.m2
smowton Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...-platforms/java/buildless-dependency-different-repository/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions ...on-tests/all-platforms/java/buildless-inherit-trust-store/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions ...tion-tests/all-platforms/java/buildless-maven-multimodule/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions ...orms/java/buildless-maven-tolerate-unavailable-dependency/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions java/ql/integration-tests/all-platforms/java/buildless-maven/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions ...ntegration-tests/all-platforms/java/buildless-proxy-maven/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions ...on-tests/all-platforms/java/buildless-snapshot-repository/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
Empty file added ...l/integration-tests/all-platforms/java/ecj-tolerate-enum-annotations/Diagnostics.expected
View file
Open in desktop
Empty file.
4 changes: 4 additions & 0 deletions java/ql/integration-tests/all-platforms/java/ecj-tolerate-enum-annotations/Diagnostics.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import semmle.code.java.Diagnostics

from Diagnostic d
select d, d.getSeverity(), d.getMessage()
9 changes: 9 additions & 0 deletions java/ql/integration-tests/all-platforms/java/ecj-tolerate-enum-annotations/Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
public enum Test {

A("A"), B("B"), C("C");

private Test(@Ann String x) { }

}

@interface Ann {}
2 changes: 2 additions & 0 deletions java/ql/integration-tests/all-platforms/java/ecj-tolerate-enum-annotations/Test2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@

public class Test2 { Test t; }
1 change: 1 addition & 0 deletions java/ql/integration-tests/all-platforms/java/ecj-tolerate-enum-annotations/test.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
| Test.java:5:16:5:28 | x | Test.java:5:16:5:19 | Ann |
8 changes: 8 additions & 0 deletions java/ql/integration-tests/all-platforms/java/ecj-tolerate-enum-annotations/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import urllib.request
from create_database_utils import *

urllib.request.urlretrieve("https://repo1.maven.org/maven2/org/eclipse/jdt/ecj/3.38.0/ecj-3.38.0.jar", "ecj.jar")

# This tests the case where ECJ emits a RuntimeIn/VisibleAnnotations attribute that isn't the same size as the corresponding method argument list, in particular due to forgetting to include the synthetic parameters added to explicit enumeration constructors.

run_codeql_database_create(["java -cp ecj.jar org.eclipse.jdt.internal.compiler.batch.Main Test.java -d out -source 8", "java -cp ecj.jar org.eclipse.jdt.internal.compiler.batch.Main Test2.java -cp out -source 8"], lang="java")
4 changes: 4 additions & 0 deletions java/ql/integration-tests/all-platforms/java/ecj-tolerate-enum-annotations/test.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import java

from Parameter p
select p, p.getAnAnnotation()
1 change: 1 addition & 0 deletions java/ql/integration-tests/all-platforms/java/java-web-jsp/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions java/ql/integration-tests/all-platforms/java/maven-enforcer/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions ...-tests/all-platforms/java/maven-sample-extract-properties/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions ...ion-tests/all-platforms/java/maven-sample-large-xml-files/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions ...ion-tests/all-platforms/java/maven-sample-small-xml-files/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions ...ration-tests/all-platforms/java/maven-sample-xml-mode-all/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions ...ion-tests/all-platforms/java/maven-sample-xml-mode-byname/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions ...n-tests/all-platforms/java/maven-sample-xml-mode-disabled/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions ...tion-tests/all-platforms/java/maven-sample-xml-mode-smart/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially
1 change: 1 addition & 0 deletions java/ql/integration-tests/all-platforms/java/maven-sample/force_sequential_test_execution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Concurrent Maven processes using ~/.m2/repository is not safe, so this test must run sequentially