Skip to content

Swift: Odds and ends #17130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffw0 merged 2 commits into from
Aug 2, 2024
Merged

Swift: Odds and ends #17130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e313fdb
Swift: Correct a comment in ECBEncryptionQuery.qll.
geoffw0 Jun 12, 2023
39411b0
Swift: Add some test of taint through 'as'.
geoffw0 Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion swift/ql/lib/codeql/swift/security/ECBEncryptionQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import codeql.swift.dataflow.TaintTracking
import codeql.swift.security.ECBEncryptionExtensions

/**
* A taint configuration from a creation of an ECB mode instance to expressions that use
* A data flow configuration from a creation of an ECB mode instance to expressions that use
* it to initialize a cipher.
*/
module EcbEncryptionConfig implements DataFlow::ConfigSig {
Expand Down
2 changes: 2 additions & 0 deletions swift/ql/test/library-tests/dataflow/taint/core/LocalTaint.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,8 @@
| simple.swift:146:7:146:7 | self | simple.swift:146:7:146:7 | SSA def(self) |
| simple.swift:148:13:148:13 | [post] self | simple.swift:146:2:150:3 | self[return] |
| simple.swift:148:13:148:13 | self | simple.swift:146:2:150:3 | self[return] |
| simple.swift:158:12:158:24 | OpaqueValueExpr | simple.swift:158:12:158:24 | OpenExistentialExpr |
| simple.swift:159:12:159:24 | OpaqueValueExpr | simple.swift:159:12:159:24 | OpenExistentialExpr |
| stringinterpolation.swift:5:7:5:7 | SSA def(self) | stringinterpolation.swift:5:7:5:7 | self[return] |
| stringinterpolation.swift:5:7:5:7 | SSA def(self) | stringinterpolation.swift:5:7:5:7 | self[return] |
| stringinterpolation.swift:5:7:5:7 | self | stringinterpolation.swift:5:7:5:7 | SSA def(self) |
Expand Down
4 changes: 4 additions & 0 deletions swift/ql/test/library-tests/dataflow/taint/core/Taint.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,6 +545,8 @@ nodes
| simple.swift:85:13:85:26 | ... .&>>(_:_:) ... | semmle.label | ... .&>>(_:_:) ... |
| simple.swift:87:13:87:21 | call to ~(_:) | semmle.label | call to ~(_:) |
| simple.swift:87:14:87:21 | call to source() | semmle.label | call to source() |
| simple.swift:156:12:156:19 | call to source() | semmle.label | call to source() |
| simple.swift:157:12:157:19 | call to source() | semmle.label | call to source() |
| stringinterpolation.swift:6:6:6:6 | self [Return] [first] | semmle.label | self [Return] [first] |
| stringinterpolation.swift:6:6:6:6 | self [first] | semmle.label | self [first] |
| stringinterpolation.swift:6:6:6:6 | value | semmle.label | value |
Expand Down Expand Up @@ -724,6 +726,8 @@ subpaths
| simple.swift:84:13:84:25 | ... .>>(_:_:) ... | simple.swift:84:13:84:20 | call to source() | simple.swift:84:13:84:25 | ... .>>(_:_:) ... | result |
| simple.swift:85:13:85:26 | ... .&>>(_:_:) ... | simple.swift:85:13:85:20 | call to source() | simple.swift:85:13:85:26 | ... .&>>(_:_:) ... | result |
| simple.swift:87:13:87:21 | call to ~(_:) | simple.swift:87:14:87:21 | call to source() | simple.swift:87:13:87:21 | call to ~(_:) | result |
| simple.swift:156:12:156:19 | call to source() | simple.swift:156:12:156:19 | call to source() | simple.swift:156:12:156:19 | call to source() | result |
| simple.swift:157:12:157:19 | call to source() | simple.swift:157:12:157:19 | call to source() | simple.swift:157:12:157:19 | call to source() | result |
| stringinterpolation.swift:22:12:22:12 | "..." | stringinterpolation.swift:19:13:19:20 | call to source() | stringinterpolation.swift:22:12:22:12 | "..." | result |
| stringinterpolation.swift:24:12:24:12 | "..." | stringinterpolation.swift:19:13:19:20 | call to source() | stringinterpolation.swift:24:12:24:12 | "..." | result |
| stringinterpolation.swift:31:12:31:12 | "..." | stringinterpolation.swift:28:14:28:21 | call to source() | stringinterpolation.swift:31:12:31:12 | "..." | result |
Expand Down
7 changes: 7 additions & 0 deletions swift/ql/test/library-tests/dataflow/taint/core/simple.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,3 +151,10 @@ class MyClass2_NeverInstantiated {
}

// ---

func taintThroughAs() {
sink(arg: source() as Int) // $ tainted=156
sink(arg: source() as Any) // $ tainted=157
sink(arg: source() as AnyObject) // $ MISSING: tainted=158
sink(arg: source() as Sendable) // $ MISSING: tainted=159
}