Skip to content

C++: Don't use operands as range analysis SSA variables #14720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MathiasVP wants to merge 3 commits into from
Closed

C++: Don't use operands as range analysis SSA variables #14720

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c8aba1
C++: Delete the operand case from range analysis SSA. This will make …
MathiasVP Nov 8, 2023
60ddf00
C++: Allow phi operand -> phi flow through inexact phi operands.
MathiasVP Nov 8, 2023
e7655ca
C++: No need for an IPA type anymore.
MathiasVP Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 6 additions & 48 deletions cpp/ql/lib/semmle/code/cpp/rangeanalysis/new/internal/semantic/SemanticExprSpecific.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,42 +128,10 @@ module SemanticExprConfig {

int getBasicBlockUniqueId(BasicBlock block) { idOf(block.getFirstInstruction().getAst(), result) }

newtype TSsaVariable =
TSsaInstruction(IR::Instruction instr) { instr.hasMemoryResult() } or
TSsaOperand(IR::Operand op) { op.isDefinitionInexact() }
class SsaVariable extends IR::Instruction {
SsaVariable() { this.hasMemoryResult() }

class SsaVariable extends TSsaVariable {
string toString() { none() }

Location getLocation() { none() }

IR::Instruction asInstruction() { none() }

IR::Operand asOperand() { none() }
}

class SsaInstructionVariable extends SsaVariable, TSsaInstruction {
IR::Instruction instr;

SsaInstructionVariable() { this = TSsaInstruction(instr) }

final override string toString() { result = instr.toString() }

final override Location getLocation() { result = instr.getLocation() }

final override IR::Instruction asInstruction() { result = instr }
}

class SsaOperand extends SsaVariable, TSsaOperand {
IR::Operand op;

SsaOperand() { this = TSsaOperand(op) }

final override string toString() { result = op.toString() }

final override Location getLocation() { result = op.getLocation() }

final override IR::Operand asOperand() { result = op }
IR::Instruction asInstruction() { result = this }
}

predicate explicitUpdate(SsaVariable v, Expr sourceExpr) {
Expand All @@ -180,9 +148,7 @@ module SemanticExprConfig {

SsaVariable getAPhiInput(SsaVariable v) {
exists(IR::PhiInstruction instr | v.asInstruction() = instr |
result.asInstruction() = instr.getAnInput()
or
result.asOperand() = instr.getAnInputOperand()
result.asInstruction() = instr.getAnInputOperand().getAnyDef()
)
}

Expand All @@ -192,11 +158,7 @@ module SemanticExprConfig {
result = getSemanticType(v.asInstruction().getResultIRType())
}

BasicBlock getSsaVariableBasicBlock(SsaVariable v) {
result = v.asInstruction().getBlock()
or
result = v.asOperand().getUse().getBlock()
}
BasicBlock getSsaVariableBasicBlock(SsaVariable v) { result = v.asInstruction().getBlock() }

private newtype TReadPosition =
TReadPositionBlock(IR::IRBlock block) or
Expand Down Expand Up @@ -263,11 +225,7 @@ module SemanticExprConfig {
pos = TReadPositionPhiInputEdge(operand.getPredecessorBlock(), operand.getUse().getBlock())
|
phi.asInstruction() = operand.getUse() and
(
input.asInstruction() = operand.getDef()
or
input.asOperand() = operand
)
input.asInstruction() = operand.getAnyDef()
)
}

Expand Down