C++: Add range analysis testcase#14708
Merged
Merged
Conversation
…we don't have IR operands as SSA variables.
geoffw0
reviewed
Nov 7, 2023
| while (x->n) { | ||
| x->n--; | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
There are no expected results for the test. It might be nice to either add some and/or explain that we're mostly checking for an analysis non-termination issue here?
Contributor
Author
There was a problem hiding this comment.
Indeed the issue here is specifically nontermination. I can add a comment if the function name doesn't make this clear 🙂
Contributor
There was a problem hiding this comment.
Yeah, it's a little odd that we're supposed to read the function name as a comment on the implementation, though we're not exactly strict about such things. I'd prefer a comment. I don't have strong feelings.
geoffw0
approved these changes
Nov 7, 2023
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Nov 7, 2023
bdrodes
pushed a commit
to microsoft/codeql
that referenced
this pull request
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This snippet causes non-terminating modulus analysis when we remove IR phi input operands as SSA variables. I think it has something to do with the non-exact phi operand, but I've yet to verify this. For now it's good to simply have this testcase included