Ruby: refine ActiveRecord update_all as an SQL sink#14627
Merged
Conversation
hmac
approved these changes
Nov 24, 2023
aibaars
reviewed
Dec 4, 2023
| // or arg0 is not of a known "safe" type | ||
| sink = call.getArgument(0) and | ||
| not ( | ||
| sink.getALocalSource() = any(DataFlow::ArrayLiteralNode arr) or |
Contributor
There was a problem hiding this comment.
This seems to implement a syntactic check to determine whether the argument is an array or hash. While this improves the status quo, I think we could use a type tracker instead to improve accuracy even more.
aibaars
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_allcallssanitize_sql_for_assignmenton array arguments which in turn callssanitize_sql_arraywhich takesary[0]as the statement andary[1..]as the values to use for bind variables in the statement. The values are sanitized before interpolation.The statement itself is still vulnerable to injection of unsanitized data, and the method can also just take a string argument which may be tainted. It can also take a hash of
field: valuepairs which I believe to be sanitized by default, though another pair of eyes on this would be good.