Skip to content

Go: Add JWT Algorithm Confusion Query #14534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kwstubbs wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Go: Add JWT Algorithm Confusion Query #14534

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a4f32dc
Add changes
Kwstubbs Oct 18, 2023
ed39d8f
Add JWT Confusion Query
Kwstubbs Oct 18, 2023
fa15d29
Formatting
Kwstubbs Oct 18, 2023
5ae082c
Minor edit
Kwstubbs Oct 18, 2023
9e939ac
fix tests
Kwstubbs Oct 18, 2023
934485d
Address Feedback and fix tests (hopefully)
Kwstubbs Oct 19, 2023
441030e
Formatting
Kwstubbs Oct 19, 2023
62a65dc
Fixed disjunt
Kwstubbs Oct 23, 2023
59b8739
Fix example
Kwstubbs Oct 24, 2023
22d215b
Manual depstubber fix
Kwstubbs Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed disjunt
  • Loading branch information
@Kwstubbs
Kwstubbs committed Oct 23, 2023
commit 62a65dca1c26cd58cb1960e8c0a33217e025dfbb
6 changes: 3 additions & 3 deletions go/ql/src/experimental/CWE-347/JWTParsingAlgorithm.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ where
func instanceof SafeJwtParserFunc
) and
//Check that the Parse(function or method) does not check the Token Method field, which most likely is a check for method type
not exists(Field f, FunctionName fn |
not exists(Field f |
f.hasQualifiedName(golangJwtModern(), "Token", "Method") and
(
f.getARead().getRoot() = c.getCall().getArgument(1)
or
c.getCall().getArgument(1) = fn and
fn.toString() = f.getARead().asExpr().getEnclosingFunction().getName()
exists(FunctionName fn | c.getCall().getArgument(1) = fn and
fn.toString() = f.getARead().asExpr().getEnclosingFunction().getName())
)
)
)
Expand Down