C++: Fix QL compiler warnings for 1.18#141
Merged
Merged
Conversation
One was for an unused parameter (a deliberate CP of `Type` x `VoidType`), and one was for use of a deprecated predicate.
ian-semmle
reviewed
Sep 3, 2018
| * numeric conversions, and otherwise the erasure is used. | ||
| */ | ||
| RefType getErasedRepr(Type t) { | ||
| t = t and // silence compiler warning |
Contributor
There was a problem hiding this comment.
There's a pattern of using suppress* predicates like private predicate suppressUnusedThis(Function f) { any() } for this, FWIW.
Contributor
Author
There was a problem hiding this comment.
I've added a commit to follow that convention.
ian-semmle
reviewed
Sep 4, 2018
| any() // stub implementation | ||
| } | ||
|
|
||
| private predicate suppressUnusedThis(Type t) { any() } |
Contributor
There was a problem hiding this comment.
Sorry, I should have clarified: Here, we aren't using it for a this variable, so it ought to be suppressUnusedType.
ian-semmle
approved these changes
Sep 4, 2018
aibaars
added a commit
that referenced
this pull request
Oct 14, 2021
Add support for multiple statements in interpolations
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Dec 6, 2021
Kotlin: Fix extraction of dispatch and extension receivers
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
…-fewer-sinks PS: Improve sinks in `powershell/command-injection`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some additional warnings in the IR about the name
Opcodebeing used for both a file and an in-line module. Those will have to be fixed after #122 is merged.