Skip to content

Go: Improved JWT query, JWT decoding without verification #14075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owen-mc merged 21 commits into from
Oct 11, 2023
Merged

Go: Improved JWT query, JWT decoding without verification #14075

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
68392e7
V1
am0o0 Aug 28, 2023
40ff16b
Merge branch 'main' into amammad-go-JWT
am0o0 Aug 29, 2023
bc6a0fc
move to CWE-347
am0o0 Sep 18, 2023
2136929
clean tests
am0o0 Sep 19, 2023
1e12a86
Merge branch 'main' into amammad-go-JWT
am0o0 Sep 19, 2023
a96b001
clean tests
am0o0 Sep 19, 2023
da864bf
fix QLDoc
am0o0 Sep 19, 2023
c78f390
add go generate support, upgrade JWT.qll
am0o0 Sep 27, 2023
8d47a7b
Update python/ql/lib/semmle/python/security/dataflow/PathInjectionQue…
am0o0 Sep 28, 2023
f0f60c3
move JWT.qll to experimental
am0o0 Sep 30, 2023
aa127b1
do review improvements
am0o0 Oct 6, 2023
7d73808
fix a test mistake, add comments for JWT extension points
am0o0 Oct 6, 2023
7d36c23
fix qhelp and PascalCase issues
am0o0 Oct 6, 2023
2579791
fix examples
am0o0 Oct 9, 2023
38b0ed8
fix issues according to codereview
am0o0 Oct 10, 2023
82483a2
fix tests
am0o0 Oct 10, 2023
db9f74b
fix tests
am0o0 Oct 10, 2023
877605d
change c to C for fixing the qhelp error :)
am0o0 Oct 10, 2023
4499048
better query quality thanks to owen
am0o0 Oct 10, 2023
5e27323
fix qldoc
am0o0 Oct 11, 2023
8a3aa2c
Fix formatting
owen-mc Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Prev Previous commit
Next Next commit
clean tests
  • Loading branch information
@am0o0
am0o0 committed Sep 19, 2023
commit 21369291646feda459ff4b588a3560f6e6186599
25 changes: 9 additions & 16 deletions go/ql/lib/semmle/go/security/JWT.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ class GolangJwtParseFromRequest extends Function {
exists(DataFlow::Function f |
f.hasQualifiedName([
"github.com/golang-jwt/jwt/request", "github.com/golang-jwt/jwt/v4/request",
"github.com/dgrijalva/jwt-go/request", "github.com/golang-jwt/jwt/v4/request",
"github.com/dgrijalva/jwt-go/v5/request"
"github.com/dgrijalva/jwt-go/request", "github.com/dgrijalva/jwt-go/v4/request"
], "ParseFromRequest")
|
this = f
Expand All @@ -125,8 +124,7 @@ class GolangJwtParseFromRequestWithClaims extends Function {
exists(DataFlow::Function f |
f.hasQualifiedName([
"github.com/golang-jwt/jwt/request", "github.com/golang-jwt/jwt/v4/request",
"github.com/dgrijalva/jwt-go/request", "github.com/golang-jwt/jwt/v4/request",
"github.com/dgrijalva/jwt-go/v5/request"
"github.com/dgrijalva/jwt-go/request", "github.com/dgrijalva/jwt-go/v4/request"
], "ParseFromRequestWithClaims")
|
this = f
Expand Down Expand Up @@ -181,13 +179,17 @@ class GoJoseUnsafeClaims extends Function {
predicate golangJwtIsAdditionalFlowStep(DataFlow::Node nodeFrom, DataFlow::Node nodeTo) {
exists(DataFlow::Function f, DataFlow::CallNode call |
f.hasQualifiedName([
"github.com/golang-jwt/jwt", "github.com/golang-jwt/jwt/v4", "github.com/golang-jwt/jwt/v5",
"github.com/dgrijalva/jwt-go", "github.com/dgrijalva/jwt-go/v4"
"github.com/golang-jwt/jwt", "github.com/golang-jwt/jwt/v4", "github.com/golang-jwt/jwt/v5"
],
[
"ParseECPrivateKeyFromPEM", "ParseECPublicKeyFromPEM", "ParseEdPrivateKeyFromPEM",
"ParseEdPublicKeyFromPEM", "ParseRSAPrivateKeyFromPEM", "ParseRSAPublicKeyFromPEM",
"RegisterSigningMethod"
]) or
f.hasQualifiedName(["github.com/dgrijalva/jwt-go", "github.com/dgrijalva/jwt-go/v4"],
[
"ParseECPrivateKeyFromPEM", "ParseECPublicKeyFromPEM", "ParseRSAPrivateKeyFromPEM",
"ParseRSAPrivateKeyFromPEMWithPassword", "ParseRSAPublicKeyFromPEM"
])
Comment thread
am0o0 marked this conversation as resolved.
Outdated
|
call = f.getACall() and
Expand All @@ -211,15 +213,6 @@ predicate golangJwtIsAdditionalFlowStep(DataFlow::Node nodeFrom, DataFlow::Node
)
}

predicate test(DataFlow::Function f, DataFlow::CallNode call) {
f.hasQualifiedName([
"gopkg.in/square/go-jose/jwt", "gopkg.in/square/go-jose.v2/jwt",
"gopkg.in/square/go-jose.v3/jwt", "github.com/go-jose/go-jose/jwt",
"github.com/go-jose/go-jose/v3/jwt"
], ["ParseEncrypted", "ParseSigned",]) and
call = f.getACall().getArgument(0)
}

predicate goJoseIsAdditionalFlowStep(DataFlow::Node nodeFrom, DataFlow::Node nodeTo) {
exists(DataFlow::Function f, DataFlow::CallNode call |
f.hasQualifiedName([
Expand Down Expand Up @@ -253,7 +246,7 @@ predicate goJoseIsAdditionalFlowStep(DataFlow::Node nodeFrom, DataFlow::Node nod
"gopkg.in/square/go-jose.v2/jwt.NestedJSONWebToken",
"gopkg.in/square/go-jose.v3/jwt.NestedJSONWebToken",
"github.com/go-jose/go-jose/jwt.NestedJSONWebToken",
"github.com/go-jose/go-jose/v3/jw.NestedJSONWebTokent"
"github.com/go-jose/go-jose/v3/jw.NestedJSONWebToken"
], "Decrypt")
|
call = f.getACall() and
Expand Down
1 change: 0 additions & 1 deletion go/ql/test/experimental/CWE-321-NoVerification/NoVerification.qlref
View file
Open in desktop

This file was deleted.

52 changes: 0 additions & 52 deletions go/ql/test/experimental/CWE-321-NoVerification/vendor/github.com/bytedance/sonic/.gitignore
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions go/ql/test/experimental/CWE-321-NoVerification/vendor/github.com/bytedance/sonic/.gitmodules
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions ...est/experimental/CWE-321-NoVerification/vendor/github.com/bytedance/sonic/.licenserc.yaml
View file
Open in desktop

This file was deleted.

128 changes: 0 additions & 128 deletions ...tal/CWE-321-NoVerification/vendor/github.com/bytedance/sonic/CODE_OF_CONDUCT.md
View file
Open in desktop

This file was deleted.

63 changes: 0 additions & 63 deletions ...mental/CWE-321-NoVerification/vendor/github.com/bytedance/sonic/CONTRIBUTING.md
View file
Open in desktop

This file was deleted.

Empty file removed go/ql/test/experimental/CWE-321-NoVerification/vendor/github.com/bytedance/sonic/CREDITS
View file
Open in desktop
Empty file.
Loading