Skip to content

Ruby: Fix some QLDoc errors in ParseRegExp.qll #13537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffw0 merged 2 commits into from
Jun 22, 2023
Merged

Ruby: Fix some QLDoc errors in ParseRegExp.qll #13537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c1637a
Ruby: Correct QLDoc for charRange.
geoffw0 Jun 22, 2023
d06f4b9
Ruby: Correct QLDoc for qualifiedPart.
geoffw0 Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ruby/ql/lib/codeql/ruby/regexp/internal/ParseRegExp.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,8 @@ abstract class RegExp extends Ast::StringlikeLiteral {

/**
* Holds if the character set starting at `charset_start` contains a character range
* with lower bound found between `start` and `lower_end`
* and upper bound found between `upper_start` and `end`.
* with lower bound found between `start` and `lowerEnd`
* and upper bound found between `upperStart` and `end`.
*/
predicate charRange(int charsetStart, int start, int lowerEnd, int upperStart, int end) {
exists(int index |
Expand Down Expand Up @@ -844,11 +844,11 @@ abstract class RegExp extends Ast::StringlikeLiteral {
}

/**
* Holds if a qualified part is found between `start` and `part_end` and the qualifier is
* found between `part_end` and `end`.
* Holds if a qualified part is found between `start` and `partEnd` and the qualifier is
* found between `partEnd` and `end`.
*
* `maybe_empty` is true if the part is optional.
* `may_repeat_forever` is true if the part may be repeated unboundedly.
* `maybeEmpty` is true if the part is optional.
* `mayRepeatForever` is true if the part may be repeated unboundedly.
*/
predicate qualifiedPart(
int start, int partEnd, int end, boolean maybeEmpty, boolean mayRepeatForever
Expand Down