Skip to content

Go: show FunctionModel steps in path summaries #13461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owen-mc merged 3 commits into from
Jun 22, 2023
Merged

Go: show FunctionModel steps in path summaries #13461

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc320c5
Never skip functionmodel inputs and outputs in path summaries
owen-mc Jun 14, 2023
c0fea85
Accept test changes
owen-mc Jun 16, 2023
0baf78f
Add change note
owen-mc Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Never skip functionmodel inputs and outputs in path summaries
  • Loading branch information
@owen-mc
owen-mc committed Jun 20, 2023
commit cc320c5e9cc217709bd10b5ac4b0cbe5d94de56d
6 changes: 5 additions & 1 deletion go/ql/lib/semmle/go/dataflow/internal/DataFlowPrivate.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,11 @@ class CastNode extends ExprNode {
* Holds if `n` should never be skipped over in the `PathGraph` and in path
* explanations.
*/
predicate neverSkipInPathGraph(Node n) { none() }
predicate neverSkipInPathGraph(Node n) {
exists(DataFlow::FunctionModel fm | fm.getAnInputNode(_) = n or fm.getAnOutputNode(_) = n)
or
exists(TaintTracking::FunctionModel fm | fm.getAnInputNode(_) = n or fm.getAnOutputNode(_) = n)
}

class DataFlowExpr = Expr;

Expand Down