Re-factor printing of summary component stacks.#13452
Merged
Merged
Conversation
f4c3fcd to
3f06055
Compare
3fba6d1 to
87a8117
Compare
hvitved
reviewed
Jun 21, 2023
Contributor
hvitved
left a comment
There was a problem hiding this comment.
LGTM, just a question about naming.
hvitved
requested changes
Jun 22, 2023
Contributor
hvitved
left a comment
There was a problem hiding this comment.
LGTM, only minor changes needed. Thanks for doing this 💪
ac77e0c to
40e8d33
Compare
hvitved
previously approved these changes
Jun 22, 2023
40e8d33 to
299481c
Compare
Contributor
Author
|
DCA looks good. |
yoff
reviewed
Jun 23, 2023
Contributor
yoff
left a comment
There was a problem hiding this comment.
I am perhaps slightly confused by the heavy focus on MaD in the QLDoc.
Is the printing not equally aligned with what is used in propagatesFlowExt?
hvitved
previously approved these changes
Jun 23, 2023
…y component stacks.
7c3bae1 to
7a5dd8d
Compare
7a5dd8d to
243c592
Compare
Contributor
Author
|
@hvitved : Only change since your last review is the last commit. |
hvitved
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we try to align then printing of summary component stacks with their textual representation as they would like, when being used in an access path (for MaD models).
Furthermore, it turns out that the existing printer
getComponentStackis not up to date for all languages. This is also fixed in this PR.