Python: container summaries, part 3#13395
Merged
Merged
Conversation
For append/add: The new results in the experimental tar slip query show that we do not recognize the sanitisers.
4b4b9bf to
b72c93f
Compare
RasmusWL
requested changes
Jun 14, 2023
Member
RasmusWL
left a comment
There was a problem hiding this comment.
Really nice to see so many MISSING: being fixed 💪 🎉 (just a few questions that needs to be resolved)
Comment on lines
+4337
to
+4345
| // existing elements | ||
| input = "Argument[self].ListElement" and | ||
| output = "ReturnValue.ListElement" and | ||
| preservesValue = true | ||
| or | ||
| // newly added element returned | ||
| input = "Argument[0]" and | ||
| output = "ReturnValue.ListElement" and | ||
| preservesValue = true |
Member
There was a problem hiding this comment.
I don't see list.append having a return value. What are these flows about? 😕
Contributor
Author
There was a problem hiding this comment.
Hm, not sure where I got this from. Neither the linked documentation nor a local experiment agrees with this..
Comment on lines
+4357
to
+4360
| // transfer taint from new element to return value | ||
| input = "Argument[0]" and | ||
| output = "ReturnValue" and | ||
| preservesValue = false |
Comment on lines
+4379
to
+4388
| // existing elements | ||
| input = "Argument[self].SetElement" and | ||
| output = "ReturnValue.SetElement" and | ||
| preservesValue = true | ||
| or | ||
| // newly added element returned | ||
| input = "Argument[0]" and | ||
| output = "ReturnValue.SetElement" and | ||
| preservesValue = true | ||
| or |
Member
There was a problem hiding this comment.
Same as above, set.add doesn't seem to have a return value when I try it out in a real ipython scenario
Comment on lines
+4398
to
+4402
| or | ||
| // transfer taint from new element to return value | ||
| input = "Argument[0]" and | ||
| output = "ReturnValue" and | ||
| preservesValue = false |
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
RasmusWL
requested changes
Jun 14, 2023
Comment on lines
+4337
to
+4341
| // existing elements | ||
| input = "Argument[self].ListElement" and | ||
| output = "ReturnValue.ListElement" and | ||
| preservesValue = true | ||
| or |
Member
There was a problem hiding this comment.
Seems like you missed these two?
Suggested change
| // existing elements | |
| input = "Argument[self].ListElement" and | |
| output = "ReturnValue.ListElement" and | |
| preservesValue = true | |
| or |
Comment on lines
+4369
to
+4373
| // existing elements | ||
| input = "Argument[self].SetElement" and | ||
| output = "ReturnValue.SetElement" and | ||
| preservesValue = true | ||
| or |
Member
There was a problem hiding this comment.
Seems like you missed these two?
Suggested change
| // existing elements | |
| input = "Argument[self].SetElement" and | |
| output = "ReturnValue.SetElement" and | |
| preservesValue = true | |
| or |
`set.add` and `list.append` do not return a value
RasmusWL
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In which we remove the final explicit taint steps from
containerStep.