Skip to content

Build: Bump build mode to C++20.#13335

Merged
sashabu merged 1 commit into
mainfrom
sashabu/c++20
Jun 13, 2023
Merged

Build: Bump build mode to C++20.#13335
sashabu merged 1 commit into
mainfrom
sashabu/c++20

Conversation

@sashabu
Copy link
Copy Markdown
Contributor

@sashabu sashabu commented May 31, 2023

No description provided.

@github-actions github-actions Bot added the Swift label May 31, 2023
@sashabu sashabu marked this pull request as ready for review June 1, 2023 11:04
@sashabu sashabu requested review from a team as code owners June 1, 2023 11:04
@sashabu sashabu added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jun 1, 2023
@sashabu sashabu force-pushed the sashabu/c++20 branch 3 times, most recently from 5f35926 to 58af7b6 Compare June 8, 2023 11:48
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be we don't need the workaround for https://cplusplus.github.io/LWG/issue3657 any more in C++20. I do hope all C++17 STL defects to be fixed in C++20.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a recent defect (opened 2022-01-02, resolved 2022-02-10). I would guess at least some of our compilers predate that. That said, we can certainly give it a try in a separate PR (so we're not adding and removing commits here to experiment). Do we have a tracking issue already?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how the C++ standard redefines the concept of "recent" 😉

I've opened https://github.com/github/codeql-c-team/issues/1777 to track this.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, I agree that doing it in a separate PR is more sensible.

Copy link
Copy Markdown
Collaborator

@criemen criemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sashabu sashabu merged commit f5d6f50 into main Jun 13, 2023
@sashabu sashabu deleted the sashabu/c++20 branch June 13, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends on internal PR This PR should only be merged in sync with an internal Semmle PR Swift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants