Ruby: rack - model redirect responses#13289
Merged
Merged
Conversation
34ab09e to
b8a5bcb
Compare
bd88fd8 to
3f772c7
Compare
…occur in a rack application
3f772c7 to
a5d8db6
Compare
…ckTracker to track instances
asgerf
reviewed
Jun 13, 2023
Co-authored-by: Asger F <asgerf@github.com>
Rack::Mime::mime_type
asgerf
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Models redirect responses from rack applications. The direct motivation behind this PR is to help detect open redirects.
The bulk of this PR is restructuring to split Rack modelling into component parts, as it's a fairly complex library.
ThemimeTypeMatchespredicate data is taken from https://www.rubydoc.info/github/rack/rack/Rack/Mime#MIME_TYPES-constant and comprises most of the diff.