QL: update regexes used in QueryDoc.getQueryName() and in QueryDoc.getQueryId()/getQueryLanguage() - #12839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests updating the regexes used in
QueryDoc.getQueryName()and inQueryDoc.getQueryId()/getQueryLanguage().The regex in
QueryDoc.getQueryName()does not work when non-word characters, such as/, are used in the query name. For example, it doesn't work with@name Depending upon JCenter/Bintray as an artifact repository.This PR proposes updating this regex to allow for any character.
The regex in
QueryDoc.getQueryId()/getQueryLanguage()does not work when a second/is used in the id. For example, it doesn't work with@id java/maven/dependency-upon-bintray.This PR proposes updating this regex to allow for a second slash. Note: the
ql/consistent-alert-messagequery returns additional results once this update is made.Let me know if there is any reason why either of these updates should not be done.