Skip to content

JavaScript: Improve query name and help for js/incomplete-sanitization.#127

Merged
semmle-qlci merged 1 commit into
github:rc/1.18from
xiemaisi:js/incomplete-sanitisation-doc-improvement
Sep 3, 2018
Merged

JavaScript: Improve query name and help for js/incomplete-sanitization.#127
semmle-qlci merged 1 commit into
github:rc/1.18from
xiemaisi:js/incomplete-sanitisation-doc-improvement

Conversation

@xiemaisi
Copy link
Copy Markdown

@xiemaisi xiemaisi commented Aug 31, 2018

The query applies more generally to all kinds of string escaping and encoding, not just sanitization.

Fixes #130.

@xiemaisi xiemaisi added the JS label Aug 31, 2018
@xiemaisi xiemaisi added this to the 1.18 milestone Aug 31, 2018
@xiemaisi xiemaisi requested a review from a team August 31, 2018 14:59
@xiemaisi
Copy link
Copy Markdown
Author

@ajafff, do you think this clarifies the intent of the query somewhat?

Copy link
Copy Markdown

@ajafff ajafff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also noticed I should have read the documentation of that query before opening the issue.

@xiemaisi xiemaisi changed the base branch from master to rc/1.18 August 31, 2018 19:36
…on`.

The query applies more generally to all kinds of string escaping and encoding, not just sanitization.
@xiemaisi xiemaisi force-pushed the js/incomplete-sanitisation-doc-improvement branch from bbc557f to 58e3845 Compare September 3, 2018 07:20
@xiemaisi xiemaisi assigned ghost Sep 3, 2018
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semmle-qlci semmle-qlci merged commit 4dec7c5 into github:rc/1.18 Sep 3, 2018
@xiemaisi xiemaisi deleted the js/incomplete-sanitisation-doc-improvement branch September 25, 2018 15:41
@kamarcum kamarcum unassigned ghost Apr 28, 2020
aibaars added a commit that referenced this pull request Oct 14, 2021
smowton pushed a commit to smowton/codeql that referenced this pull request Dec 6, 2021
Kotlin: Small fixes and a little more documentation for TrapWriter
MathiasVP added a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
…tion

PS: Fix if statement clause extraction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants