Skip to content

JS: Improve insufficient pw hash query#12666

Merged
asgerf merged 14 commits into
github:mainfrom
smiddy007:improve-insufficient-pw-hash-query
Mar 31, 2023
Merged

JS: Improve insufficient pw hash query#12666
asgerf merged 14 commits into
github:mainfrom
smiddy007:improve-insufficient-pw-hash-query

Conversation

@smiddy007
Copy link
Copy Markdown
Contributor

Added to the crypto-js library module to match progressive hashing in order to improve InsufficientPasswordHash.ql. Also added example js files and renamed existing example files as being Node-js examples.

@smiddy007 smiddy007 requested a review from a team as a code owner March 27, 2023 03:10
Comment thread javascript/ql/lib/semmle/javascript/frameworks/CryptoLibraries.qll Fixed
Comment thread javascript/ql/lib/semmle/javascript/frameworks/CryptoLibraries.qll Fixed
Comment thread javascript/ql/lib/semmle/javascript/frameworks/CryptoLibraries.qll Fixed
@smiddy007
Copy link
Copy Markdown
Contributor Author

edit

@owen-mc owen-mc changed the title Improve insufficient pw hash query JS: Improve insufficient pw hash query Mar 28, 2023
Copy link
Copy Markdown
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just one comment so far

Comment thread javascript/ql/lib/semmle/javascript/frameworks/CryptoLibraries.qll Outdated
@smiddy007 smiddy007 requested a review from asgerf March 28, 2023 15:31
Copy link
Copy Markdown
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@asgerf asgerf merged commit dec1e4d into github:main Mar 31, 2023
@smiddy007 smiddy007 deleted the improve-insufficient-pw-hash-query branch April 5, 2023 20:09
@smiddy007 smiddy007 restored the improve-insufficient-pw-hash-query branch April 5, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants