Java: merge the @class and @interface database types and tables#12111
Merged
smowton merged 6 commits intoFeb 15, 2023
Merged
Conversation
igfoo
reviewed
Feb 6, 2023
d8bc174 to
dade459
Compare
This will allow the extractor to emit class(id, ...) when all it knows about a class is its name, due to not having it available on the classpath. Previously it would have had to guess whether it belonged to @Class or @interface, possibly introducing an inconsistency.
Also fix a simple redundancy noticed while debugging
dade459 to
62d10f9
Compare
aschackmull
reviewed
Feb 15, 2023
| ) { | ||
| exists(RefType commonSourceDecl | | ||
| unificationTargets(pt1, pt2) and | ||
| pragma[only_bind_out](pt1).getSourceDeclaration() = pragma[only_bind_out](commonSourceDecl) and |
Contributor
There was a problem hiding this comment.
The pragma on the RHS looks superfluous to me.
aschackmull
approved these changes
Feb 15, 2023
Contributor
aschackmull
left a comment
There was a problem hiding this comment.
One minor comment, otherwise LGTM. I presume that the up- and downgrade scripts have been tested, because AFAIR our automated testing for those doesn't quite test as much as one could hope for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow the extractor to emit class(id, ...) when all it knows about a class is its name, due to not having it available on the classpath. Previously it would have had to guess whether it belonged to
@classor@interface, possibly introducing an inconsistency.