ReDoS: fix canonicalization in NfaUtils#11071
Merged
Merged
Conversation
2 tasks
asgerf
approved these changes
Nov 7, 2022
erik-krogh
added a commit
to erik-krogh/ql
that referenced
this pull request
Nov 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cc = getCanonicalCharClass(term)predicate got a char-class for the canonical representativeterm, so it was not meant to be used unless you already had the canonical representative.That wasn't how it was used in
js/incomplete-multi-character-sanitization, which caused a FN when I converted the regex code to a shared pack.(Some sorting got slightly changed, which changed the canonicalization a tiny bit).
Evaluation looks good: Python, Ruby, Java, JavaScript.
Performance is neutral, and there are a few more results that were erroneously missing due to the bad canonicalization.