QL: allow getURL as an acronym#10605
Conversation
08c84ef to
2b31647
Compare
kaeluka
left a comment
There was a problem hiding this comment.
Strictly speaking, that change means that users can write their own getURL methods (right?), but this implementation still seems to strike a good balance between precision and complexity.
People can write their own getURL predicate, yes. See https://codeql.github.com/docs/writing-codeql-queries/providing-locations-in-codeql-queries/#providing-urls. |
Yes, and that was always the case, now they just don't get a warning when they do it. The I got some FPs due to that in another PR, so that's why I'm doing this PR. |
getURLis a language feature, so it should be allowed as an upper-case acronym.