Skip to content

Ruby: Add missing edges to the call graph for singleton methods#10296

Merged
hvitved merged 2 commits into
github:mainfrom
hvitved:ruby/call-graph-missing-singletons
Sep 6, 2022
Merged

Ruby: Add missing edges to the call graph for singleton methods#10296
hvitved merged 2 commits into
github:mainfrom
hvitved:ruby/call-graph-missing-singletons

Conversation

@hvitved
Copy link
Copy Markdown
Contributor

@hvitved hvitved commented Sep 5, 2022 •
edited
Loading

Call targets were missing for singleton method calls inside uncalled singleton methods:

class Singletons
    def self.singleton_a
        self.singleton_b # missing call target, when there is no call to `singleton_a`
    end

    def self.singleton_b
    end
end

@github-actions github-actions Bot added the Ruby label Sep 5, 2022
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Sep 5, 2022
@hvitved hvitved marked this pull request as ready for review September 5, 2022 17:52
@hvitved hvitved requested a review from a team as a code owner September 5, 2022 17:52
@hvitved hvitved merged commit b2c38b3 into github:main Sep 6, 2022
@hvitved hvitved deleted the ruby/call-graph-missing-singletons branch September 6, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aibaars aibaars aibaars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-change-note-required This PR does not need a change note Ruby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hvitved @aibaars