Python: Add testcase for import problem#10176
Merged
Merged
Conversation
tausbn
approved these changes
Sep 6, 2022
Contributor
tausbn
left a comment
There was a problem hiding this comment.
Thank you for this comprehensive test case! 👍
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Feb 23, 2023
It's nice that it fixes the `InsecureProtocol` test-case (which maybe should have been a test-case for the import resolution library in the first place?) But it's not quite right: 1. it adds spurious flow for `clashing_attr` 2. it runs into huge problems for typetracking_imports/tracked.expected 3. it runs into the problem for github#10176 with an `from <pkg> import *` blocking flow from previously defined variable, that is NOT overridden. (simplistic_reexport.bar_attr)
dilanbhalla
pushed a commit
to microsoft/codeql
that referenced
this pull request
Apr 20, 2023
It's nice that it fixes the `InsecureProtocol` test-case (which maybe should have been a test-case for the import resolution library in the first place?) But it's not quite right: 1. it adds spurious flow for `clashing_attr` 2. it runs into huge problems for typetracking_imports/tracked.expected 3. it runs into the problem for github#10176 with an `from <pkg> import *` blocking flow from previously defined variable, that is NOT overridden. (simplistic_reexport.bar_attr)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently ordering is currently important when using
import *😬 We should fix that, but here is a test-case to reproduce 😊