Skip to content

[GHSA-crjg-w57m-rqqf] DNSJava vulnerable to KeyTrap - Denial-of-Service Algorithmic Complexity Attacks#4787

Merged
advisory-database[bot] merged 1 commit intoamita-seal/advisory-improvement-4787from
amita-seal-GHSA-crjg-w57m-rqqf
Sep 11, 2024
Merged

[GHSA-crjg-w57m-rqqf] DNSJava vulnerable to KeyTrap - Denial-of-Service Algorithmic Complexity Attacks#4787
advisory-database[bot] merged 1 commit intoamita-seal/advisory-improvement-4787from
amita-seal-GHSA-crjg-w57m-rqqf

Conversation

@amita-seal
Copy link
Copy Markdown

Updates

  • Affected products

Comments
Based on dnsjava/dnsjava@07ac36a and dnsjava/dnsjava@3ddc45c
Vulnerability is irrelevant to the origin version, the fix is in dnssec folder, which was only added in version 3.5, as per changelog

@github
Copy link
Copy Markdown
Collaborator

github commented Sep 11, 2024

Hi there @ibauersachs! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@github-actions github-actions bot changed the base branch from main to amita-seal/advisory-improvement-4787 September 11, 2024 07:27
@darakian
Copy link
Copy Markdown
Contributor

@amita-seal, I assume this is the change log entry
https://github.com/dnsjava/dnsjava/releases/tag/v3.5.0
and this is the relevant PR?
dnsjava/dnsjava#209

@ibauersachs
Copy link
Copy Markdown

While the proposed change is technically correct (and the referenced PR), it would require to flag org.jitsi:dnssecjava (all versions, won't fix since it's archived) instead.

@darakian
Copy link
Copy Markdown
Contributor

@ibauersachs not sure I follow. Are you saying that all versions of org.jitsi:dnssecjava should be marked as vulnerable to this issue?
eg.
org.jitsi:dnssecjava <= 2.0.0

Is that in addition to the artifact dnsjava:dnsjava?

@ibauersachs
Copy link
Copy Markdown

Yes, that is in addition to dnsjava >= 3.5.0.

I thought I did that already when I released the bulletins. It's possible I couldn't do that though, and thus left dnsjava marked as vulnerable including versions before 3.5 since that indirectly points users to migrate to the fixed dnsjava version.

@darakian
Copy link
Copy Markdown
Contributor

OK cool. Many thanks for the clarification. I'll set dnsjava:dnsjava to have a lower bound at 3.5.0 and add org.jitsi:dnssecjava <= 2.0.0 as an additional affected product as that seems to belong to you as well @ibauersachs.

The affected products will show
dnsjava:dnsjava with a VVR >= 3.5.0, < 3.6.0
and
org.jitsi:dnssecjava with a VVR of <= 2.0.0

Many thanks to both of you :)

For the sake of future readers
org.jitsi:dnssecjava on maven central refers to
https://github.com/ibauersachs/dnssecjava
as its project url.

@advisory-database advisory-database bot merged commit fcacbf0 into amita-seal/advisory-improvement-4787 Sep 11, 2024
@advisory-database
Copy link
Copy Markdown
Contributor

Hi @amita-seal! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

@advisory-database advisory-database bot deleted the amita-seal-GHSA-crjg-w57m-rqqf branch September 11, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants