Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Use modern clone dialog when re-cloning a repository #2202

Merged
jcansdale merged 4 commits into from
Jan 29, 2019
Merged

Use modern clone dialog when re-cloning a repository #2202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1da1d9f
Use modern clone/open dialog when re-cloning
jcansdale Jan 28, 2019
818b02e
Remove obsolete ReCloneDialog
jcansdale Jan 28, 2019
c24aefe
Merge branch 'master' into fixes/2199-reclone-using-new-open-clone-di…
jcansdale Jan 28, 2019
9102daf
Merge branch 'master' into fixes/2199-reclone-using-new-open-clone-di…
jcansdale Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove obsolete ReCloneDialog
  • Loading branch information
@jcansdale
jcansdale committed Jan 28, 2019
commit 818b02e58edc595e0076ff7b78eb1d84b49ac586
25 changes: 0 additions & 25 deletions src/GitHub.App/SampleData/RepositoryRecloneViewModelDesigner.cs
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions src/GitHub.App/Services/DialogService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,6 @@ public async Task<CloneDialogResult> ShowCloneDialog(IConnection connection, str
}
}

public async Task<string> ShowReCloneDialog(RepositoryModel repository)
{
Guard.ArgumentNotNull(repository, nameof(repository));

var viewModel = factory.CreateViewModel<IRepositoryRecloneViewModel>();
viewModel.SelectedRepository = repository;
return (string)await showDialog.ShowWithFirstConnection(viewModel);
}

public async Task ShowCreateGist(IConnection connection)
{
var viewModel = factory.CreateViewModel<IGistCreationViewModel>();
Expand Down
162 changes: 0 additions & 162 deletions src/GitHub.App/ViewModels/Dialog/RepositoryRecloneViewModel.cs
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions src/GitHub.Exports.Reactive/ViewModels/Dialog/IRepositoryRecloneViewModel.cs
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions src/GitHub.Exports/Services/IDialogService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,6 @@ public interface IDialogService
/// </returns>
Task<CloneDialogResult> ShowCloneDialog(IConnection connection, string url = null);

/// <summary>
/// Shows the re-clone dialog.
/// </summary>
/// <param name="repository">The repository to clone.</param>
/// <returns>
/// A task that returns the base path for the clone on success, or null if the dialog was
/// cancelled.
/// </returns>
/// <remarks>
/// The re-clone dialog is shown from the VS2017+ start page when the user wants to check
/// out a repository that was previously checked out on another machine.
/// </remarks>
Task<string> ShowReCloneDialog(RepositoryModel repository);

/// <summary>
/// Shows the Create Gist dialog.
/// </summary>
Expand Down
Loading