Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Unify the repository list and URL tabs in the clone dialog #2197

Merged
jcansdale merged 16 commits into from
Feb 5, 2019
Merged

Unify the repository list and URL tabs in the clone dialog #2197

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3a810e9
Add tests for RepositorySelectViewModel.Filter
jcansdale Jan 23, 2019
2e2f2f5
Allow searching by repository URL
jcansdale Jan 23, 2019
5571cb7
Allow user to enter repository URL in filter
jcansdale Jan 23, 2019
2a7d2fc
Change prompt text to "Search or enter a URL"
jcansdale Jan 23, 2019
09580ef
Remove the URL tab
jcansdale Jan 23, 2019
dbbaa8d
Allow filtering my owner URL
jcansdale Jan 23, 2019
fe2a04f
Merge branch 'master' into fixes/2187-unify-repository-list-tabs
jcansdale Jan 28, 2019
5113951
Open clone dialog on tab for URL
jcansdale Jan 28, 2019
a9de3ec
Merge branch 'master' into fixes/2187-unify-repository-list-tabs
jcansdale Jan 29, 2019
f288a04
Check host name is case insensative
jcansdale Jan 29, 2019
de69b1d
Remove obsolete metrics and tests
jcansdale Jan 29, 2019
7ee5fed
Remove unused logger
jcansdale Jan 29, 2019
c4a4793
Merge branch 'master' into fixes/2187-unify-repository-list-tabs
jcansdale Jan 29, 2019
b33ed8b
Merge branch 'master' into fixes/2187-unify-repository-list-tabs
StanleyGoldman Feb 1, 2019
fde9cb1
Match repos with a trailing / or .git
jcansdale Feb 4, 2019
761e780
Merge branch 'master' into fixes/2187-unify-repository-list-tabs
jcansdale Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Match repos with a trailing / or .git
  • Loading branch information
@jcansdale
jcansdale committed Feb 4, 2019
commit fde9cb1f79cc3fdc43c530d7a567cf14303d93cc
7 changes: 6 additions & 1 deletion src/GitHub.App/ViewModels/Dialog/Clone/RepositorySelectViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,14 @@ bool FilterItem(object obj)
{
if (obj is IRepositoryItemViewModel item && !string.IsNullOrWhiteSpace(Filter))
{
var urlString = item.Url.ToString();
var urlStringWithGit = urlString + ".git";
var urlStringWithSlash = urlString + "/";
return
item.Caption.Contains(Filter, StringComparison.CurrentCultureIgnoreCase) ||
item.Url.ToString().Contains(Filter, StringComparison.OrdinalIgnoreCase);
urlString.Contains(Filter, StringComparison.OrdinalIgnoreCase) ||
urlStringWithGit.Contains(Filter, StringComparison.OrdinalIgnoreCase) ||
urlStringWithSlash.Contains(Filter, StringComparison.OrdinalIgnoreCase);
}

return true;
Expand Down
2 changes: 2 additions & 0 deletions test/GitHub.App.UnitTests/ViewModels/Dialog/Clone/RepositorySelectViewModelTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ public class TheFilterProperty
[TestCase("HTTPS://GITHUB.COM/OWNER/NAME", "owner", "name", "https://github.com/owner/name", 1)]
[TestCase("https://github.com/owner", "owner", "name", "https://github.com/owner/name", 1)]
[TestCase("https://github.com/jcansdale/TestDriven.Net", "owner", "name", "https://github.com/jcansdale/TestDriven.Net-issues", 1)]
[TestCase("https://github.com/owner/name/", "owner", "name", "https://github.com/owner/name", 1, Description = "Trailing slash")]
[TestCase("https://github.com/owner/name.git", "owner", "name", "https://github.com/owner/name", 1, Description = "Trailing .git")]
public async Task Filter(string filter, string owner, string name, string url, int expectCount)
{
var contributedToRepositories = new[]
Expand Down