Skip to content

css: improvements to "move the left margin" #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chriscool merged 3 commits into from
Dec 2, 2020
Merged

css: improvements to "move the left margin" #471

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48d22b0
css: move the max-width to the site
felipec Dec 2, 2020
5719155
css: improve width of main containers
felipec Dec 2, 2020
64756a3
css: remove extra padding
felipec Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
css: move the max-width to the site 
This allows the wrapper to fit the whole width of the window, and align
the contained elements properly.

The width of the navbar is 20em (280px), so the max-width of the site is
940px - 280px, thus retaining the original width.

This fixes the issue with "Git Rev News: Edition 68" where the site width
was too big, and the navbar width got too small.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
  • Loading branch information
Felipe Contreras committed Dec 2, 2020
commit 48d22b074a544bdf767afd85d8eb01a001d674dc
3 changes: 2 additions & 1 deletion css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ body {
-webkit-flex: 1;
-ms-flex: 1;
flex: 1;
max-width: 660px;
}

.navbar {
Expand All @@ -62,7 +63,7 @@ body {
display: -ms-flexbox;
display: flex;
margin: 0 auto;
max-width: 940px;
justify-content: center;
}

@media (max-width: 700px) {
Expand Down