environment: migrate trust_executable_bit (test)#2316
Open
malon7782 wants to merge 3 commits into
Open
Conversation
added 3 commits
May 27, 2026 18:33
The 'read-cache.c' file already includes 'environment.h', which provides the extern declarations for variables like 'trust_executable_bit' and 'has_symlinks'. Remove the redundant extern declarations inside 'st_mode_from_ce()' to clean up the code. Mentored-by: Christian Couder <christian.couder@gamil.com> Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com> Signed-off-by: Tian Yuchen <cat@malon.dev>
The ce_mode_from_stat() function is declared as a static inline function in 'read-cache.h'. As we want to migrate configuration variables, this helper function will need access to corresponding repository-specific configuration logic. Move the implementation to 'read-cache.c' to cleanly encapsulate its dependencies. Mentored-by: Christian Couder <christian.couder@gamil.com> Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com> Signed-off-by: Tian Yuchen <cat@malon.dev>
Move the global 'trust_executable_bit' configuration into the repository-specific 'repo_config_values' struct. For now, associated functions in read-cache.c access this configuration by explicitly falling back to 'the_repository'. Mentored-by: Christian Couder <christian.couder@gamil.com> Mentored-by: Ayush Chandekar <ayu.chandekar@gmail.com> Signed-off-by: Tian Yuchen <cat@malon.dev>
|
There is an issue in commit 87e5acf:
|
87e5acf to
7207106
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit series is currently for test use. Will refine associated descriptions once completed.
#2312