Add balance data for 5.0.15 by HADB · Pull Request #227 · ggtracker/sc2reader

HADB · 2026-05-25T11:21:45Z

Add balance data for 5.0.15.

Fixes:

Missing ability 5840 from Build
Missing ability 59E0 from Build
Missing ability 5A80 from Build
Missing ability 5B40 from Build
Missing ability 5B60 from Build
Missing ability 5B80 from Build
Missing ability 5BA0 from Build

cclauss · 2026-05-25T19:51:32Z

Would it be possible to add some pytests that would fail on the current codebase but pass on this pull request?

Final job step of https://app.circleci.com/pipelines/github/ggtracker/sc2reader/214/workflows/ad8c6a59-d43a-40c4-8a38-6d66c2627021/jobs/955

HADB · 2026-05-26T02:31:51Z

I added some test replay files that log ERRORs when loaded on the current codebase, but pass without errors on this PR.

logs on the current codebase

(sc2reader) ➜  sc2reader git:(current) python -m pytest test_replays/test_replays.py::TestReplays::test_5_0_15 --log-cli-level=ERROR
============================================================= test session starts ==============================================================
platform darwin -- Python 3.14.3, pytest-9.0.3, pluggy-1.6.0
rootdir: /Users/bean/Projects/github.com/HADB/sc2reader
configfile: pyproject.toml
collected 1 item                                                                                                                               

test_replays/test_replays.py::TestReplays::test_5_0_15 
---------------------------------------------------------------- live log call -----------------------------------------------------------------
ERROR    sc2reader.events.game.CommandEvent:context.py:35 test_replays/5.0.15/95405_0.SC2Replay
ERROR    sc2reader.events.game.CommandEvent:context.py:36 Release String: 5.0.15.95405
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 1 - TcAA (Terran)
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 2 - SKYLINEROPE (Protoss)
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 3 - llllllllllll (Protoss)
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 4 - HADB (Terran)
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 11406     SKYLINEROPE     Missing ability 5840 from Build
ERROR    sc2reader.events.game.CommandEvent:context.py:35 test_replays/5.0.15/95435_0.SC2Replay
ERROR    sc2reader.events.game.CommandEvent:context.py:36 Release String: 5.0.15.95435
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 1 - fate (Protoss)
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 2 - HADB (Terran)
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 4704      fate    Missing ability 5A80 from Build
ERROR    sc2reader.events.game.CommandEvent:context.py:35 test_replays/5.0.15/96314_0.SC2Replay
ERROR    sc2reader.events.game.CommandEvent:context.py:36 Release String: 5.0.15.96314
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 1 - GivePower (Zerg)
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 2 - HADB (Terran)
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 4863      GivePower       Missing ability 5B40 from Build
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 9766      HADB    Missing ability 5BA0 from Build
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 13653     GivePower       Missing ability 5B40 from Build
ERROR    sc2reader.events.game.CommandEvent:context.py:35 test_replays/5.0.15/96516_0.SC2Replay
ERROR    sc2reader.events.game.CommandEvent:context.py:36 Release String: 5.0.15.96516
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 1 - HADB (Terran)
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 2 - WindMoon (Terran)
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 6201      WindMoon        Missing ability 1531 from Build
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 9186      WindMoon        Missing ability 59E0 from Build
ERROR    sc2reader.events.game.CommandEvent:context.py:35 test_replays/5.0.15/96516_1.SC2Replay
ERROR    sc2reader.events.game.CommandEvent:context.py:36 Release String: 5.0.15.96516
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 1 - 路边一条的小虫子 (Protoss)
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 2 - HADB (Terran)
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 7557      路边一条的小虫子        Missing ability 5B80 from Build
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 7637      路边一条的小虫子        Missing ability 5A80 from Build
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 8685      路边一条的小虫子        Missing ability 5B80 from Build
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 11230     路边一条的小虫子        Missing ability 5840 from Build
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 12021     路边一条的小虫子        Missing ability 5B80 from Build
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 14168     路边一条的小虫子        Missing ability 5840 from Build
ERROR    sc2reader.events.game.CommandEvent:context.py:35 test_replays/5.0.15/96999_0.SC2Replay
ERROR    sc2reader.events.game.CommandEvent:context.py:36 Release String: 5.0.15.96999
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 1 - HADB (Terran)
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 2 - 夜色初上 (Protoss)
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 5435      夜色初上        Missing ability 5B80 from Build
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 7671      HADB    Missing ability 5BA0 from Build
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 10182     HADB    Missing ability 5BA0 from Build
PASSED                                                                                                                                   [100%]

============================================================== 1 passed in 0.30s ===============================================================

logs on this PR

(sc2reader) ➜  sc2reader git:(current) python -m pytest test_replays/test_replays.py::TestReplays::test_5_0_15 --log-cli-level=ERROR
============================================================= test session starts ==============================================================
platform darwin -- Python 3.14.3, pytest-9.0.3, pluggy-1.6.0
rootdir: /Users/bean/Projects/github.com/HADB/sc2reader
configfile: pyproject.toml
collected 1 item                                                                                                                               

test_replays/test_replays.py::TestReplays::test_5_0_15 PASSED                                                                            [100%]

============================================================== 1 passed in 0.28s ===============================================================

for more information, see https://pre-commit.ci

HADB · 2026-05-26T06:43:26Z

I pushed a new commit(b37a6de) that fixes another 'missing ability' error — this one occurred when canceling an add-on on Barracks/Factory/Starport.

logs before this commit:

(sc2reader) ➜  sc2reader git:(current) ✗ python -m pytest test_replays/test_replays.py::TestReplays::test_5_0_15 --log-cli-level=ERROR
================================================================== test session starts ==================================================================
platform darwin -- Python 3.14.3, pytest-9.0.2, pluggy-1.6.0
rootdir: /Users/bean/Projects/github.com/HADB/sc2reader
configfile: pyproject.toml
collected 1 item                                                                                                                                        

test_replays/test_replays.py::TestReplays::test_5_0_15 
--------------------------------------------------------------------- live log call ---------------------------------------------------------------------
ERROR    sc2reader.events.game.CommandEvent:context.py:35 test_replays/5.0.15/96999_1_133E.SC2Replay
ERROR    sc2reader.events.game.CommandEvent:context.py:36 Release String: 5.0.15.96999
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 1 - IIIIIIIIIIII (Protoss)
ERROR    sc2reader.events.game.CommandEvent:context.py:43       Player 2 - HADB (Terran)
ERROR    sc2reader.engine.plugins.context.ContextLoader:context.py:45 5002      HADB    Missing ability 133E from Build
PASSED                                                                                                                                            [100%]

=================================================================== 1 passed in 1.97s ===================================================================

logs on this commit

(sc2reader) ➜  sc2reader git:(fix/missing-canceladdon-abilities) ✗ python -m pytest test_replays/test_replays.py::TestReplays::test_5_0_15 --log-cli-level=ERROR
===================================================================== test session starts =====================================================================
platform darwin -- Python 3.14.3, pytest-9.0.2, pluggy-1.6.0
rootdir: /Users/bean/Projects/github.com/HADB/sc2reader
configfile: pyproject.toml
collected 1 item                                                                                                                                              

test_replays/test_replays.py::TestReplays::test_5_0_15 PASSED                                                                                           [100%]

====================================================================== 1 passed in 0.28s ======================================================================

cclauss

Nice!

StoicLoofah

Thanks!

Add balance data for 5.0.15

30a54ad

Add test replays

d81b537

pre-commit-ci Bot and others added 2 commits May 26, 2026 02:33

[pre-commit.ci] auto fixes from pre-commit.com hooks

a2a5627

for more information, see https://pre-commit.ci

Fix missing CancelAddon abilities

b37a6de

cclauss approved these changes May 26, 2026

View reviewed changes

StoicLoofah approved these changes May 27, 2026

View reviewed changes

StoicLoofah merged commit 9971869 into ggtracker:upstream May 27, 2026
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add balance data for 5.0.15#227

Add balance data for 5.0.15#227
StoicLoofah merged 4 commits into
ggtracker:upstreamfrom
HADB:upstream

HADB commented May 25, 2026

Uh oh!

cclauss commented May 25, 2026 •

edited

Loading

Uh oh!

HADB commented May 26, 2026

Uh oh!

HADB commented May 26, 2026 •

edited

Loading

Uh oh!

cclauss left a comment

Uh oh!

StoicLoofah left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

HADB commented May 25, 2026

Uh oh!

cclauss commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HADB commented May 26, 2026

logs on the current codebase

logs on this PR

Uh oh!

HADB commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

logs before this commit:

logs on this commit

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

StoicLoofah left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cclauss commented May 25, 2026 •

edited

Loading

HADB commented May 26, 2026 •

edited

Loading