Fix: examples/sc2autosave.py update to Python 3#210
Merged
Conversation
cclauss
approved these changes
Apr 30, 2025
cclauss
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Can you please add a line or two to the commit message above to tell us how you tested this and what the results were?
Fixed the file by modifying it to use dict() instead of a custom diction that was deleted, modify the map-name parameter to work with the current library, the example was try with python 3.11 with the command: `python .\examples\sc2autosave.py <source> <dest> --rename "{matchup}/({length}) {map} {teams}" --length "%M:%S"` a few parameters are yet to be tested
StoicLoofah
approved these changes
May 3, 2025
StoicLoofah
left a comment
Collaborator
There was a problem hiding this comment.
This looks good. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed the file sc2autosave.py following the #208 issue by adapting it to Python3