Dialog control event#201
Merged
Merged
Conversation
Contributor
Author
|
Style check is failing on a function since it thinks "assertIn" is a typo :) |
Collaborator
|
Add sc2reader/.circleci/config.yml Line 21 in a7778d0 |
StoicLoofah
approved these changes
May 30, 2024
StoicLoofah
left a comment
Collaborator
There was a problem hiding this comment.
Do you mind running black so it can clean up the formatting?
I can also pop it on top if it's tricky for you to get that in
Contributor
Author
|
Yep, it was a wee agressive in readers.py |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the DialogControlEvent game event type.
This is for interactions with dialogs ingame and allows for some neat data collection as it looks to generate an event when a trigger modifys a dialog field aswell.
Control ID seems for the most part useless
Event types seem to match with the ones listed here https://mapster.talv.space/galaxy/reference/preset-control-event-type
Event data contains what a dialog text box was changedto, if a check box checked or unchecked, etc