Repository navigation
rpc : do not leave or serve truncated cache files - #30648
Open
TonyWu2333 wants to merge 1 commit into
Open
TonyWu2333 wants to merge 1 commit into
TonyWu2333 wants to merge 1 commit into
Conversation
Write cache files to a temp path and rename them only after a successful write, and treat empty or unreadable cache files as a cache miss. Fixes ggml-org#30633
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
When
rpc-server -cfails to write a cache file (e.g. disk full), it leaves a truncated or empty file under the cache dir. On later requestsget_cached_filetreats that file as a valid hit and serves the truncated data, which silently corrupts weights.This PR:
<hash>.tmpfirst and renames to<hash>only after a successful write; on failure the temp file is removed and a warning is loggedget_cached_file, so the client falls back to sending the full tensorFixes #30633
Additional information
test-rpc-multi-servernow starts server A with-cand a tempLLAMA_CACHE, pre-creates an empty cache file for a weights tensor, and checks thatset_tensorstill round-trips the correct data and that no empty or.tmpfiles are left in the cache dir afterwards.Requirements