fix: add 308 redirect support (RFC 7538)#242
Merged
ml31415 merged 2 commits intoMay 9, 2026
Merged
Conversation
ml31415
reviewed
May 9, 2026
| for item in ("cookie", "cookie2"): | ||
| self.headers.discard(item) | ||
|
|
||
| def redirect(self, code, location): |
Collaborator
There was a problem hiding this comment.
Please also have a look here. This never got the necessary love to really be RFC compliant, just to be "good enough" for common use cases.
Contributor
Author
|
@ml31415 done. |
Collaborator
|
Thanks for your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add HTTP 308 (Permanent Redirect, RFC 7538) to
valid_response_codesandredirect_resonse_codesinUserAgent. Previously, 308 responses weretreated as errors and never followed.
Changes
src/geventhttpclient/useragent.py: Add308to bothvalid_response_codesandredirect_resonse_codesfrozensets.tests/test_useragent.py: Addcheck_redirect_308()WSGI handlerand
test_redirect_308()test.Rationale
RFC 7538 standardized 308 as "Permanent Redirect" — semantically identical
to 301 but preserving the HTTP method (like 307). All other common redirect
statuses (301, 302, 303, 307) were already supported; 308 was the missing
counterpart.
Testing
test_redirect_308()passes: 308 → follows Location → 200 OK